[DSC-2730] fix jasmine tests

Author: Andrea Barbasso

src/app/core/shared/metadata.utils.spec.ts

@@ -54,7 +54,7 @@ const testMethod = (fn, resultKind, mapOrMaps, keyOrKeys, hitHighlights, expecte
   const keys = keyOrKeys instanceof Array ? keyOrKeys : [keyOrKeys];
   describe('and key' + (keys.length === 1 ? (' ' + keys[0]) : ('s ' + JSON.stringify(keys)))
     + ' with ' + (isUndefined(filter) ? 'no filter' : 'filter ' + JSON.stringify(filter)), () => {
-    const result = fn(mapOrMaps, keys, hitHighlights, filter, limit);
+    const result = fn(mapOrMaps, keys, hitHighlights, filter, false, limit);
     let shouldReturn;
     if (resultKind === 'boolean') {
       shouldReturn = expected;
@@ -304,10 +304,9 @@ describe('Metadata', () => {
 
   });
 
-  // TODO: check why limit seems not to be working (it returns 2 elements instead of 1)
-  xdescribe('all method with limit', () => {
+  describe('all method with limit', () => {
     const testAllWithLimit = (mapOrMaps, keyOrKeys, expected, limit) =>
-      testMethod(Metadata.all, 'value', mapOrMaps, keyOrKeys, expected, undefined, limit);
+      testMethod(Metadata.all, 'value', mapOrMaps, keyOrKeys, undefined, expected, undefined, limit);
 
     describe('with multiMap and limit', () => {
       testAllWithLimit(multiMap, 'dc.title', [dcTitle1], 1);

src/app/core/shared/metadata.utils.ts

@@ -64,7 +64,7 @@ export class Metadata {
             if (Metadata.valueMatches(candidate as MetadataValue, filter)) {
               matches.push(candidate as MetadataValue);
               if (hasValue(limit) && matches.length >= limit) {
-                return  matches;
+                return matches;
               }
             }
           }
@@ -89,7 +89,7 @@ export class Metadata {
         }
       }
     }
-    return matches;
+    return matches.slice(0, hasValue(limit) ? limit : matches.length);
   }
 
   /**

src/app/shared/object-list/my-dspace-result-list-element/item-list-preview/item-list-preview.component.spec.ts

@@ -152,23 +152,21 @@ describe('ItemListPreviewComponent', () => {
     component.object = { hitHighlights: {} } as any;
   });
 
-  // TODO: Investigate why this test is failing with ExpressionChangedAfterItHasBeenCheckedError
-  xdescribe('When showThumbnails is true', () => {
+  describe('When showThumbnails is true', () => {
     beforeEach(() => {
       component.item = mockItemWithAuthorAndDate;
-      fixture.detectChanges();
+      fixture.detectChanges(false);
     });
     it('should add the thumbnail element', () => {
       const thumbnail = fixture.debugElement.query(By.css('ds-thumbnail'));
       expect(thumbnail).toBeTruthy();
     });
   });
 
-  // TODO: Investigate why this test is failing with ExpressionChangedAfterItHasBeenCheckedError
-  xdescribe('When the item has an author', () => {
+  describe('When the item has an author', () => {
     beforeEach(() => {
       component.item = mockItemWithAuthorAndDate;
-      fixture.detectChanges();
+      fixture.detectChanges(false);
     });
 
     it('should show the author paragraph', () => {
@@ -180,7 +178,7 @@ describe('ItemListPreviewComponent', () => {
   describe('When the item has no author', () => {
     beforeEach(() => {
       component.item = mockItemWithoutAuthorAndDate;
-      fixture.detectChanges();
+      fixture.detectChanges(false);
     });
 
     it('should not show the author paragraph', () => {
@@ -189,11 +187,10 @@ describe('ItemListPreviewComponent', () => {
     });
   });
 
-  // TODO: Investigate why this test is failing with ExpressionChangedAfterItHasBeenCheckedError
-  xdescribe('When the item has an issuedate', () => {
+  describe('When the item has an issuedate', () => {
     beforeEach(() => {
       component.item = mockItemWithAuthorAndDate;
-      fixture.detectChanges();
+      fixture.detectChanges(false);
     });
 
     it('should show the issuedate span', () => {
@@ -205,7 +202,7 @@ describe('ItemListPreviewComponent', () => {
   describe('When the item has no issuedate', () => {
     beforeEach(() => {
       component.item = mockItemWithoutAuthorAndDate;
-      fixture.detectChanges();
+      fixture.detectChanges(false);
     });
 
     it('should show the issuedate empty placeholder', () => {
@@ -218,7 +215,7 @@ describe('ItemListPreviewComponent', () => {
     beforeEach(() => {
       component.item = mockItemWithEntityType;
       component.showLabel = true;
-      fixture.detectChanges();
+      fixture.detectChanges(false);
     });
 
     it('should show the badges', () => {
@@ -231,7 +228,7 @@ describe('ItemListPreviewComponent', () => {
     beforeEach(() => {
       component.item = mockItemWithEntityType;
       component.showLabel = false;
-      fixture.detectChanges();
+      fixture.detectChanges(false);
     });
 
     it('should not show the badges', () => {
@@ -241,12 +238,11 @@ describe('ItemListPreviewComponent', () => {
   });
 
 
-  // TODO: Investigate why this test is failing with ExpressionChangedAfterItHasBeenCheckedError
-  xdescribe('When truncatable section is collapsed', () => {
+  describe('When truncatable section is collapsed', () => {
     beforeEach(() => {
       component.isCollapsed$ = of(true);
       component.item = mockItemWithAuthorAndDate;
-      fixture.detectChanges();
+      fixture.detectChanges(false);
     });
 
     it('should show limitedMetadata', () => {
@@ -255,12 +251,11 @@ describe('ItemListPreviewComponent', () => {
     });
   });
 
-  // TODO: Investigate why this test is failing with ExpressionChangedAfterItHasBeenCheckedError
-  xdescribe('When truncatable section is expanded', () => {
+  describe('When truncatable section is expanded', () => {
     beforeEach(() => {
       component.isCollapsed$ = of(false);
       component.item = mockItemWithAuthorAndDate;
-      fixture.detectChanges();
+      fixture.detectChanges(false);
     });
 
     it('should show allMetadata', () => {
@@ -318,24 +313,22 @@ describe('ItemListPreviewComponent', () => {
     component.object = { hitHighlights: {} } as any;
   });
 
-  // TODO: Investigate why this test is failing with ExpressionChangedAfterItHasBeenCheckedError
-  xdescribe('When showThumbnails is true', () => {
+  describe('When showThumbnails is true', () => {
     beforeEach(() => {
       component.item = mockItemWithAuthorAndDate;
-      fixture.detectChanges();
+      fixture.detectChanges(false);
     });
     it('should add the thumbnail element', () => {
       const thumbnail = fixture.debugElement.query(By.css('ds-thumbnail'));
       expect(thumbnail).toBeFalsy();
     });
   });
 
-  // TODO: Investigate why this test is failing with ExpressionChangedAfterItHasBeenCheckedError
-  xdescribe('When showCorrection is false', () => {
+  describe('When showCorrection is false', () => {
     beforeEach(() => {
       component.item = mockItemWithAuthorAndDate;
       component.showCorrection = false;
-      fixture.detectChanges();
+      fixture.detectChanges(false);
     });
 
     it('should not show the correction badge', () => {