[DSC-1661] check canCorrectItem feature

Author: Andrea Barbasso

src/app/search-page/configuration-search-page.component.ts

@@ -9,7 +9,7 @@ import { RouteService } from '../core/services/route.service';
 import { SearchService } from '../core/shared/search/search.service';
 import { Router } from '@angular/router';
 import { SearchManager } from '../core/browse/search-manager';
-import { ConfigurationDataService } from '../core/data/configuration-data.service';
+import { AuthorizationDataService } from '../core/data/feature-authorization/authorization-data.service';
 
 /**
  * This component renders a search page using a configuration as input.
@@ -37,7 +37,7 @@ export class ConfigurationSearchPageComponent extends SearchComponent {
               @Inject(SEARCH_CONFIG_SERVICE) public searchConfigService: SearchConfigurationService,
               protected routeService: RouteService,
               protected router: Router,
-              protected configurationService: ConfigurationDataService,) {
-    super(service, searchManager, sidebarService, windowService, searchConfigService, platformId, routeService, router, configurationService);
+              protected authorizationService: AuthorizationDataService,) {
+    super(service, searchManager, sidebarService, windowService, searchConfigService, platformId, routeService, router, authorizationService);
   }
 }

src/app/shared/search/search.component.spec.ts

@@ -5,7 +5,7 @@ import { RouterTestingModule } from '@angular/router/testing';
 import { Store } from '@ngrx/store';
 import { TranslateModule } from '@ngx-translate/core';
 import { cold } from 'jasmine-marbles';
-import { BehaviorSubject, Observable, of as observableOf } from 'rxjs';
+import { BehaviorSubject, Observable, of, of as observableOf } from 'rxjs';
 import { SortDirection, SortOptions } from '../../core/cache/models/sort-options.model';
 import { CommunityDataService } from '../../core/data/community-data.service';
 import { HostWindowService } from '../host-window.service';
@@ -34,15 +34,15 @@ import { SearchFilterConfig } from './models/search-filter-config.model';
 import { FilterType } from './models/filter-type.model';
 import { getCommunityPageRoute } from '../../community-page/community-page-routing-paths';
 import { getCollectionPageRoute } from '../../collection-page/collection-page-routing-paths';
-import { ConfigurationDataService } from '../../core/data/configuration-data.service';
+import { AuthorizationDataService } from '../../core/data/feature-authorization/authorization-data.service';
 
 let comp: SearchComponent;
 let fixture: ComponentFixture<SearchComponent>;
 let searchServiceObject: SearchService;
 let searchConfigurationServiceObject: SearchConfigurationService;
 
-const configurationDataService = jasmine.createSpyObj('configurationDataService', {
-  findByPropertyName: createSuccessfulRemoteDataObject$({ values: ['true'] })
+const authorizationDataService = jasmine.createSpyObj('authorizationDataService', {
+  isAuthorized: of(true)
 });
 
 const store: Store<SearchComponent> = jasmine.createSpyObj('store', {
@@ -247,8 +247,8 @@ export function configureSearchComponentTestingModule(compType, additionalDeclar
         useValue: searchConfigurationServiceStub
       },
       {
-        provide: ConfigurationDataService,
-        useValue: configurationDataService
+        provide: AuthorizationDataService,
+        useValue: authorizationDataService
       }
     ],
     schemas: [NO_ERRORS_SCHEMA]

src/app/shared/search/search.component.ts

@@ -51,7 +51,8 @@ import { COMMUNITY_MODULE_PATH } from '../../community-page/community-page-routi
 import { SearchManager } from '../../core/browse/search-manager';
 import { AlertType } from '../alert/alert-type';
 import { isPlatformServer } from '@angular/common';
-import { ConfigurationDataService } from '../../core/data/configuration-data.service';
+import { FeatureID } from '../../core/data/feature-authorization/feature-id';
+import { AuthorizationDataService } from '../../core/data/feature-authorization/authorization-data.service';
 
 @Component({
   selector: 'ds-search',
@@ -375,7 +376,7 @@ export class SearchComponent implements OnInit, OnDestroy {
     @Inject(SEARCH_CONFIG_SERVICE) public searchConfigService: SearchConfigurationService,
     protected routeService: RouteService,
     protected router: Router,
-    protected configurationService: ConfigurationDataService,) {
+    protected authorizationService: AuthorizationDataService,) {
     this.isXsOrSm$ = this.windowService.isXsOrSm();
   }
 
@@ -394,18 +395,8 @@ export class SearchComponent implements OnInit, OnDestroy {
 
     if (this.showCorrection === null || this.showCorrection === undefined) {
       this.subs.push(
-        this.configurationService.findByPropertyName('context-menu-entry.requestcorrection.enabled').pipe(
-          getFirstCompletedRemoteData(),
-          map((res) => {
-            switch (res?.payload?.values[0]) {
-              case 'true':
-                return true;
-              case 'false':
-              default:
-                return false;
-            }
-          }),
-        ).subscribe((showCorrection) => {
+        this.authorizationService.isAuthorized(FeatureID.CanCorrectItem, null, null, true)
+        .subscribe((showCorrection) => {
           this.showCorrection = showCorrection;
         }));
     }