Skip to content

Commit 2ef7874

Browse files
committed
Name resolution changed in Node 18 -- avoid it.
1 parent 7690d36 commit 2ef7874

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

.github/workflows/build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ jobs:
112112
start: yarn run serve:ssr
113113
# Wait for backend & frontend to be available
114114
# NOTE: We use the 'sites' REST endpoint to also ensure the database is ready
115-
wait-on: http://localhost:8080/server/api/core/sites, http://localhost:4000
115+
wait-on: http://127.0.0.1:8080/server/api/core/sites, http://127.0.0.1:4000
116116
# Wait for 2 mins max for everything to respond
117117
wait-on-timeout: 120
118118

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ https://wiki.lyrasis.org/display/DSDOC7x/Installing+DSpace
3535
Quick start
3636
-----------
3737

38-
**Ensure you're running [Node](https://nodejs.org) `v14.x` or `v16.x`, [npm](https://www.npmjs.com/) >= `v5.x` and [yarn](https://yarnpkg.com) == `v1.x`**
38+
**Ensure you're running [Node](https://nodejs.org) `v16.x` or `v18.x`, [npm](https://www.npmjs.com/) >= `v5.x` and [yarn](https://yarnpkg.com) == `v1.x`**
3939

4040
```bash
4141
# clone the repo
@@ -90,7 +90,7 @@ Requirements
9090
------------
9191

9292
- [Node.js](https://nodejs.org) and [yarn](https://yarnpkg.com)
93-
- Ensure you're running node `v14.x` or `v16.x` and yarn == `v1.x`
93+
- Ensure you're running node `v16.x` or `v18.x` and yarn == `v1.x`
9494

9595
If you have [`nvm`](https://github.com/creationix/nvm#install-script) or [`nvm-windows`](https://github.com/coreybutler/nvm-windows) installed, which is highly recommended, you can run `nvm install --lts && nvm use` to install and start using the latest Node LTS.
9696

0 commit comments

Comments
 (0)