Skip to content

Commit 2432925

Browse files
committed
Fix docker network inconsistencies in compose files & re-sync REST compose files with backend codebase.
1 parent c2258bf commit 2432925

5 files changed

Lines changed: 23 additions & 3 deletions

File tree

docker/cli.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ networks:
1616
# Default to using network named 'dspacenet' from docker-compose-rest.yml.
1717
# Its full name will be prepended with the project name (e.g. "-p d7" means it will be named "d7_dspacenet")
1818
# If COMPOSITE_PROJECT_NAME is missing, default value will be "docker" (name of folder this file is in)
19-
default:
19+
dspacenet:
2020
name: ${COMPOSE_PROJECT_NAME:-docker}_dspacenet
2121
external: true
2222
services:
@@ -34,6 +34,8 @@ services:
3434
db__P__url: 'jdbc:postgresql://dspacedb:5432/dspace'
3535
# solr.server: Ensure we are using the 'dspacesolr' image for Solr
3636
solr__P__server: http://dspacesolr:8983/solr
37+
networks:
38+
- dspacenet
3739
volumes:
3840
# Keep DSpace assetstore directory between reboots
3941
- assetstore:/dspace/assetstore

docker/docker-compose-ci.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,8 @@ services:
116116
cp -r /opt/solr/server/solr/configsets/qaevent/* qaevent
117117
precreate-core suggestion /opt/solr/server/solr/configsets/suggestion
118118
cp -r /opt/solr/server/solr/configsets/suggestion/* suggestion
119+
precreate-core audit /opt/solr/server/solr/configsets/audit
120+
cp -r /opt/solr/server/solr/configsets/audit/* audit
119121
chown -R solr:solr /var/solr
120122
runuser -u solr -- solr-foreground
121123
volumes:

docker/docker-compose-dist.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,11 @@
99
# Docker Compose for running the DSpace Angular UI dist build
1010
# for previewing with the DSpace Demo site backend
1111
networks:
12+
# Default to using network named 'dspacenet' from docker-compose.yml.
13+
# Its full name will be prepended with the project name (e.g. "-p d7" means it will be named "d7_dspacenet")
1214
dspacenet:
15+
name: ${COMPOSE_PROJECT_NAME}_dspacenet
16+
external: true
1317
services:
1418
dspace-angular:
1519
container_name: dspace-angular
@@ -31,7 +35,7 @@ services:
3135
context: ..
3236
dockerfile: Dockerfile.dist
3337
networks:
34-
dspacenet:
38+
- dspacenet
3539
ports:
3640
- published: 4000
3741
target: 4000

docker/docker-compose-rest.yml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,10 @@ networks:
1717
# Define a custom subnet for our DSpace network, so that we can easily trust requests from host to container.
1818
# If you customize this value, be sure to customize the 'proxies.trusted.ipranges' env variable below.
1919
- subnet: 172.23.0.0/16
20+
# Explicitly set external=false because this script creates the network.
21+
# NOTE: Because of how compose files are merged, this script should be specified LAST when passed
22+
# to "docker compose" for the network to be created properly.
23+
external: false
2024
services:
2125
# DSpace (backend) webapp container
2226
dspace:
@@ -36,6 +40,8 @@ services:
3640
db__P__url: 'jdbc:postgresql://dspacedb:5432/dspace'
3741
# solr.server: Ensure we are using the 'dspacesolr' image for Solr
3842
solr__P__server: http://dspacesolr:8983/solr
43+
# matomo.tracker.url: Ensure we are using the 'matomo' image for Matomo
44+
matomo__P__tracker__P__url: http://matomo
3945
# proxies.trusted.ipranges: This setting is required for a REST API running in Docker to trust requests
4046
# from the host machine. This IP range MUST correspond to the 'dspacenet' subnet defined above.
4147
proxies__P__trusted__P__ipranges: '172.23.0'
@@ -126,6 +132,8 @@ services:
126132
cp -r /opt/solr/server/solr/configsets/qaevent/* qaevent
127133
precreate-core suggestion /opt/solr/server/solr/configsets/suggestion
128134
cp -r /opt/solr/server/solr/configsets/suggestion/* suggestion
135+
precreate-core audit /opt/solr/server/solr/configsets/audit
136+
cp -r /opt/solr/server/solr/configsets/audit/* audit
129137
chown -R solr:solr /var/solr
130138
runuser -u solr -- solr-foreground
131139
volumes:

docker/docker-compose.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,11 @@
1010
# Requires also running a REST API backend (either locally or remotely),
1111
# for example via 'docker-compose-rest.yml'
1212
networks:
13+
# Default to using an existing external network named 'dspacenet' (created in docker-compose-rest.yml)
14+
# Its full name will be prepended with the project name (e.g. "-p d7" means it will be named "d7_dspacenet")
1315
dspacenet:
16+
name: ${COMPOSE_PROJECT_NAME}_dspacenet
17+
external: true
1418
services:
1519
dspace-angular:
1620
container_name: dspace-angular
@@ -28,7 +32,7 @@ services:
2832
context: ..
2933
dockerfile: Dockerfile
3034
networks:
31-
dspacenet:
35+
- dspacenet
3236
ports:
3337
- published: 4000
3438
target: 4000

0 commit comments

Comments
 (0)