Skip to content

Commit 20146bd

Browse files
author
Kuno Vercammen
committed
114599: Updated the e2e tests so they succeed
1 parent 6ff3a40 commit 20146bd

4 files changed

Lines changed: 7 additions & 8 deletions

File tree

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
beforeEach(() => {
2-
cy.visit('/collections/create');
2+
cy.visit('/collections/create?parent='.concat(Cypress.env('DSPACE_TEST_COMMUNITY')));
33
cy.loginViaForm(Cypress.env('DSPACE_TEST_ADMIN_USER'), Cypress.env('DSPACE_TEST_ADMIN_PASSWORD'));
44
});
55

@@ -9,5 +9,5 @@ it('should show loading component while saving', () => {
99

1010
cy.get('button[type="submit"]').click();
1111

12-
cy.get('ds-themed-loading').should('be.visible');
12+
cy.get('ds-loading').should('be.visible');
1313
});

cypress/e2e/community-create.cy.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,5 +9,5 @@ it('should show loading component while saving', () => {
99

1010
cy.get('button[type="submit"]').click();
1111

12-
cy.get('ds-themed-loading').should('be.visible');
12+
cy.get('ds-loading').should('be.visible');
1313
});

src/app/collection-page/create-collection-page/create-collection-page.component.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,7 @@
1-
import { AsyncPipe, NgIf } from '@angular/common';
1+
import {
2+
AsyncPipe,
3+
NgIf,
4+
} from '@angular/common';
25
import { Component } from '@angular/core';
36
import { Router } from '@angular/router';
47
import {
@@ -16,7 +19,6 @@ import { CreateComColPageComponent } from '../../shared/comcol/comcol-forms/crea
1619
import { ThemedLoadingComponent } from '../../shared/loading/themed-loading.component';
1720
import { NotificationsService } from '../../shared/notifications/notifications.service';
1821
import { CollectionFormComponent } from '../collection-form/collection-form.component';
19-
import { LoadingComponent } from '../../../themes/custom/app/shared/loading/loading.component';
2022

2123
/**
2224
* Component that represents the page where a user can create a new Collection
@@ -30,7 +32,6 @@ import { LoadingComponent } from '../../../themes/custom/app/shared/loading/load
3032
TranslateModule,
3133
AsyncPipe,
3234
ThemedLoadingComponent,
33-
LoadingComponent,
3435
NgIf,
3536
],
3637
standalone: true,

src/app/community-page/create-community-page/create-community-page.component.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ import { ThemedLoadingComponent } from '../../shared/loading/themed-loading.comp
1919
import { NotificationsService } from '../../shared/notifications/notifications.service';
2020
import { VarDirective } from '../../shared/utils/var.directive';
2121
import { CommunityFormComponent } from '../community-form/community-form.component';
22-
import { LoadingComponent } from '../../../themes/custom/app/shared/loading/loading.component';
2322

2423
/**
2524
* Component that represents the page where a user can create a new Community
@@ -35,7 +34,6 @@ import { LoadingComponent } from '../../../themes/custom/app/shared/loading/load
3534
NgIf,
3635
AsyncPipe,
3736
ThemedLoadingComponent,
38-
LoadingComponent,
3937
],
4038
standalone: true,
4139
})

0 commit comments

Comments
 (0)