[DURACOM-413] add redirect on no-content response

Author: FrancescoMolinaro

src/app/core/shared/authorized.operators.ts

@@ -56,6 +56,28 @@ export const redirectOn4xx = <T>(router: Router, authService: AuthService) =>
       }),
       map(([rd]: [RemoteData<T>, boolean]) => rd),
     );
+
+
+/**
+ * Redirect to 404 if the requested content is not found (204 No Content)
+ *
+ * @param router
+ * @param authService
+ */
+export const redirectOn204 = <T>(router: Router, authService: AuthService) =>
+  (source: Observable<RemoteData<T>>): Observable<RemoteData<T>> =>
+    source.pipe(
+      withLatestFrom(authService.isAuthenticated()),
+      filter(([rd, isAuthenticated]: [RemoteData<T>, boolean]) => {
+        if (rd.hasNoContent) {
+          router.navigateByUrl(getPageNotFoundRoute(), { skipLocationChange: true });
+          return false;
+        }
+        return true;
+      }),
+      map(([rd]: [RemoteData<T>, boolean]) => rd),
+    );
+
 /**
  * Operator that returns a UrlTree to a forbidden page or the login page when the boolean received is false
  * @param router      The router used to navigate to a forbidden page

src/app/item-page/item-page.resolver.ts

@@ -15,7 +15,10 @@ import { RemoteData } from '@dspace/core/data/remote-data';
 import { ResolvedAction } from '@dspace/core/resolving/resolver.actions';
 import { getItemPageRoute } from '@dspace/core/router/utils/dso-route.utils';
 import { HardRedirectService } from '@dspace/core/services/hard-redirect.service';
-import { redirectOn4xx } from '@dspace/core/shared/authorized.operators';
+import {
+  redirectOn4xx,
+  redirectOn204,
+} from '@dspace/core/shared/authorized.operators';
 import {
   getItemPageLinksToFollow,
   Item,
@@ -56,6 +59,7 @@ export const itemPageResolver: ResolveFn<RemoteData<Item>> = (
     ...getItemPageLinksToFollow(),
   ).pipe(
     getFirstCompletedRemoteData(),
+    redirectOn204<Item>(router, authService),
     redirectOn4xx(router, authService),
   );