Skip to content

Commit 1752b1a

Browse files
100479: Removed the default input values to make it possible to override them in themes
1 parent d6147e5 commit 1752b1a

6 files changed

Lines changed: 10 additions & 14 deletions

File tree

src/app/footer/themed-footer.component.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import { FooterComponent } from './footer.component';
77
*/
88
@Component({
99
selector: 'ds-themed-footer',
10-
styleUrls: ['footer.component.scss'],
10+
styleUrls: [],
1111
templateUrl: '../shared/theme-support/themed.component.html',
1212
})
1313
export class ThemedFooterComponent extends ThemedComponent<FooterComponent> {
@@ -20,6 +20,6 @@ export class ThemedFooterComponent extends ThemedComponent<FooterComponent> {
2020
}
2121

2222
protected importUnthemedComponent(): Promise<any> {
23-
return import(`./footer.component`);
23+
return import('./footer.component');
2424
}
2525
}

src/app/header-nav-wrapper/themed-header-navbar-wrapper.component.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,11 @@ import { ThemedComponent } from '../shared/theme-support/themed.component';
33
import { HeaderNavbarWrapperComponent } from './header-navbar-wrapper.component';
44

55
/**
6-
* Themed wrapper for BreadcrumbsComponent
6+
* Themed wrapper for {@link HeaderNavbarWrapperComponent}
77
*/
88
@Component({
99
selector: 'ds-themed-header-navbar-wrapper',
10-
styleUrls: ['./themed-header-navbar-wrapper.component.scss'],
10+
styleUrls: [],
1111
templateUrl: '../shared/theme-support/themed.component.html',
1212
})
1313
export class ThemedHeaderNavbarWrapperComponent extends ThemedComponent<HeaderNavbarWrapperComponent> {
@@ -20,6 +20,6 @@ export class ThemedHeaderNavbarWrapperComponent extends ThemedComponent<HeaderNa
2020
}
2121

2222
protected importUnthemedComponent(): Promise<any> {
23-
return import(`./header-navbar-wrapper.component`);
23+
return import('./header-navbar-wrapper.component');
2424
}
2525
}

src/app/home-page/themed-home-page.component.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@ import { Component } from '@angular/core';
88
templateUrl: '../shared/theme-support/themed.component.html',
99
})
1010
export class ThemedHomePageComponent extends ThemedComponent<HomePageComponent> {
11-
protected inAndOutputNames: (keyof HomePageComponent & keyof this)[];
12-
1311

1412
protected getComponentName(): string {
1513
return 'HomePageComponent';

src/app/my-dspace-page/themed-my-dspace-page.component.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ import { MyDSpacePageComponent } from './my-dspace-page.component';
1111
templateUrl: './../shared/theme-support/themed.component.html'
1212
})
1313
export class ThemedMyDSpacePageComponent extends ThemedComponent<MyDSpacePageComponent> {
14-
protected inAndOutputNames: (keyof MyDSpacePageComponent & keyof this)[];
1514

1615
protected getComponentName(): string {
1716
return 'MyDSpacePageComponent';

src/app/search-page/themed-configuration-search-page.component.ts

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,19 +28,18 @@ export class ThemedConfigurationSearchPageComponent extends ThemedComponent<Conf
2828
/**
2929
* True when the search component should show results on the current page
3030
*/
31-
@Input() inPlaceSearch = true;
31+
@Input() inPlaceSearch: boolean;
3232

3333
/**
3434
* Whether or not the search bar should be visible
3535
*/
36-
@Input()
37-
searchEnabled = true;
36+
@Input() searchEnabled: boolean;
3837

3938
/**
4039
* The width of the sidebar (bootstrap columns)
4140
*/
4241
@Input()
43-
sideBarWidth = 3;
42+
sideBarWidth: number;
4443

4544
/**
4645
* The currently applied configuration (determines title of search)
@@ -66,7 +65,7 @@ export class ThemedConfigurationSearchPageComponent extends ThemedComponent<Conf
6665
}
6766

6867
protected importUnthemedComponent(): Promise<any> {
69-
return import(`./configuration-search-page.component`);
68+
return import('./configuration-search-page.component');
7069
}
7170

7271
}

src/app/shared/search/search.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ export class SearchComponent implements OnInit {
127127
/**
128128
* List of available view mode
129129
*/
130-
@Input() useUniquePageId: false;
130+
@Input() useUniquePageId: boolean;
131131

132132
/**
133133
* List of available view mode

0 commit comments

Comments
 (0)