Skip to content

Commit 152acdd

Browse files
Mattia Vianellivins01-4science
authored andcommitted
Merged in DSC-1491_maintenance_cris_fix (pull request DSpace#1276)
DSC-1491 - Infinite scroll on modal fix Approved-by: Vincenzo Mecca
2 parents 2125965 + 7348eca commit 152acdd

2 files changed

Lines changed: 7 additions & 2 deletions

File tree

src/app/shared/dso-selector/dso-selector/dso-selector.component.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,12 @@
66
[formControl]="input" ngbAutofocus (keyup.enter)="selectSingleResult()">
77
</div>
88
<div class="dropdown-divider"></div>
9-
<div class="scrollable-menu list-group">
9+
<div id="scrollable-menu-dso-selector-{{randomSeed}}" class="scrollable-menu list-group">
1010
<div
1111
infiniteScroll
1212
[infiniteScrollDistance]="1"
1313
[infiniteScrollThrottle]="0"
14-
[infiniteScrollContainer]="'.scrollable-menu'"
14+
[infiniteScrollContainer]="'#scrollable-menu-dso-selector-' + randomSeed"
1515
[fromRoot]="true"
1616
(scrolled)="onScrollDown()">
1717
<ng-container *ngIf="listEntries$ | async">

src/app/shared/dso-selector/dso-selector/dso-selector.component.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,11 @@ export class DSOSelectorComponent implements OnInit, OnDestroy {
142142
*/
143143
public subs: Subscription[] = [];
144144

145+
/**
146+
* Random seed of 4 characters to avoid duplicate ids
147+
*/
148+
randomSeed: string = Math.random().toString(36).substring(2, 6);
149+
145150
constructor(
146151
protected searchService: SearchService,
147152
protected notifcationsService: NotificationsService,

0 commit comments

Comments
 (0)