[UXP-206] try to use given coordinates if nominatim api fails

Author: Andrea Barbasso

src/app/core/services/location.service.ts

@@ -25,7 +25,7 @@ export enum LocationErrorCodes {
   API_ERROR = 'api-error',
 }
 
-const IS_DD_COORDINATE_PAIR_REGEXP = /^\d+\.?\d*,\d+\.?\d*$/;
+const IS_DD_COORDINATE_PAIR_REGEXP = /^\d+\.?\d*,\s?\d+\.?\d*$/;
 const IS_SG_COORDINATE_PAIR_REGEXP = /^[NS] *\d+° *\d+['′] *\d+(?:"|″|\.\d+),? *[EW] *\d+° *\d+['′] *\d+(?:"|″|\.\d+)|\d+° *\d+['′] *\d+(?:"|″|\.\d+) *[NS],? *\d+° *\d+['′] *\d+(?:"|″|\.\d+) *[EW]$/;
 
 const NOMINATIM_RESPONSE_FORMAT = 'jsonv2';
@@ -176,8 +176,8 @@ export class LocationService {
   public isValidCoordinateString(coordinateString: string): boolean {
     if (this.isDecimalCoordinateString(coordinateString)) {
       const coordinateArray = coordinateString.split(',');
-      const latitude = parseFloat(coordinateArray[0]);
-      const longitude = parseFloat(coordinateArray[1]);
+      const latitude = parseFloat(coordinateArray[0].trim());
+      const longitude = parseFloat(coordinateArray[1].trim());
       return !isNaN(latitude) && !isNaN(longitude) && this.isValidDecimalCoordinatePair(latitude, longitude);
     } else {
       return false;

src/app/shared/open-street-map/open-street-map.component.ts

@@ -170,6 +170,12 @@ export class OpenStreetMapComponent implements OnInit {
         },
         error: (err) => {
           this.invalidLocationErrorCode.next(err.message); // either INVALID_COORDINATES or API_ERROR
+          // show the map centered on provided coordinates despite the possibility to retrieve a description for the place
+          const coordinates = this.locationService.parseCoordinates(position);
+          const place: LocationPlace = {
+            coordinates: coordinates,
+          };
+          this.place.next(place);
           if (err.message === LocationErrorCodes.API_ERROR) {
             console.error(err.message);
           } else {
@@ -189,6 +195,12 @@ export class OpenStreetMapComponent implements OnInit {
         },
         error: (err) => {
           this.invalidLocationErrorCode.next(err.message); // either LOCATION_NOT_FOUND or API_ERROR
+          // show the map centered on provided coordinates despite the possibility to retrieve a description for the place
+          const coordinates = this.locationService.parseCoordinates(position);
+          const place: LocationPlace = {
+            coordinates: coordinates,
+          };
+          this.place.next(place);
           if (err.message === LocationErrorCodes.API_ERROR) {
             console.error(err.message);
           } else {