Merged in task/dspace-cris-2025_02_x/DSC-2683 (pull request DSpace#4020)

Mattia Vianelli · Andrea Barbasso · commit 08f84af87820 · 2026-01-28T10:36:51.000Z
DSC-2683 Fix admin sidebar logic to enable external links

Approved-by: Andrea Barbasso
diff --git a/src/app/admin/admin-sidebar/admin-sidebar-section/admin-sidebar-section.component.ts b/src/app/admin/admin-sidebar/admin-sidebar-section/admin-sidebar-section.component.ts
@@ -59,7 +59,7 @@ export class AdminSidebarSectionComponent extends AbstractMenuSectionComponent i
 
   ngOnInit(): void {
     // todo: should support all menu entries?
-    this.isDisabled = this.itemModel?.disabled || isEmpty(this.itemModel?.link);
+    this.isDisabled = this.itemModel?.disabled || (isEmpty(this.itemModel?.link) && isEmpty(this.itemModel?.href));
     super.ngOnInit();
   }
 

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ export class AdminSidebarSectionComponent extends AbstractMenuSectionComponent i`
`59`	`59`
`60`	`60`	`ngOnInit(): void {`
`61`	`61`	`// todo: should support all menu entries?`
`62`		`- this.isDisabled = this.itemModel?.disabled \|\| isEmpty(this.itemModel?.link);`
	`62`	`+ this.isDisabled = this.itemModel?.disabled \|\| (isEmpty(this.itemModel?.link) && isEmpty(this.itemModel?.href));`
`63`	`63`	`super.ngOnInit();`
`64`	`64`	`}`
`65`	`65`