[UXP-123] Code cleaning

Author: atarix83

src/app/item-page/cris-item-page-tab.resolver.ts

@@ -51,9 +51,10 @@ export class CrisItemPageTabResolver implements Resolve<RemoteData<PaginatedList
               if (tabsRD.hasSucceeded && tabsRD?.payload?.page?.length > 0) {
                 // By splitting the url with uuid we can understand if the item is primary item page or a tab
                 const urlSplit = state.url.split(route.params.id);
-                const givenTab = urlSplit[1];
+                const tabArguments = urlSplit[1]?.split('/');
+                const givenTab = tabArguments[1];
                 const itemPageRoute = getItemPageRoute(itemRD.payload);
-                const isValidTab = tabsRD.payload.page.some((tab) => !givenTab || `/${tab.shortname}` === givenTab);
+                const isValidTab = tabsRD.payload.page.some((tab) => !givenTab || tab.shortname === givenTab);
 
                 const mainTab = tabsRD.payload.page.length === 1
                   ? tabsRD.payload.page[0]
@@ -62,7 +63,7 @@ export class CrisItemPageTabResolver implements Resolve<RemoteData<PaginatedList
                 if (!isValidTab) {
                   // If wrong tab is given redirect to 404 page
                   this.router.navigateByUrl(getPageNotFoundRoute(), { skipLocationChange: true, replaceUrl: false });
-                } else if (givenTab === `/${mainTab.shortname}`) {
+                } else if (givenTab === mainTab.shortname) {
                   // If first tab is given redirect to root item page
                   this.hardRedirectService.redirect(itemPageRoute, 302);
                 }