[DURACOM-455] optimize file download link template

Author: FrancescoMolinaro

src/app/shared/file-download-link/file-download-link.component.html

@@ -1,23 +1,27 @@
 @if (showAccessStatusBadge) {
   <ds-access-status-badge [object]="bitstream"></ds-access-status-badge>
 }
-<a [routerLink]="(bitstreamPath$| async)?.routerLink" class="d-block dont-break-out mb-1"
-  [queryParams]="(bitstreamPath$| async)?.queryParams"
+@let bitstreamPath = bitstreamPath$ | async;
+@let canDownload = canDownload$ | async;
+@let canDownloadWithToken = canDownloadWithToken$ | async;
+
+<a [routerLink]="bitstreamPath?.routerLink" class="d-block dont-break-out mb-1"
+  [queryParams]="bitstreamPath?.queryParams"
   [target]="isBlank ? '_blank': '_self'"
   [ngClass]="cssClasses"
-  [attr.aria-label]="getDownloadLinkTitle(canDownload$ | async, canDownloadWithToken$ | async, dsoNameService.getName(bitstream))"
-  [title]="getDownloadLinkTitle(canDownload$ | async, canDownloadWithToken$ | async, dsoNameService.getName(bitstream))"
+  [attr.aria-label]="getDownloadLinkTitle(canDownload, canDownloadWithToken, dsoNameService.getName(bitstream))"
+  [title]="getDownloadLinkTitle(canDownload, canDownloadWithToken, dsoNameService.getName(bitstream))"
   role="link"
   tabindex="0">
-  @if ((canDownload$ | async) === false && (canDownloadWithToken$ | async) === false) {
+  @if ((canDownload) === false && (canDownloadWithToken) === false) {
     <!-- If the user cannot download the file by auth or token, show a lock icon -->
     <span role="img"
     [attr.aria-label]="'file-download-link.restricted' | translate"
     [title]="'file-download-link.restricted' | translate"
     class="pe-1">
       <i class="fas fa-lock"></i>
     </span>
-  } @else if ((canDownloadWithToken$ | async) && (canDownload$ | async) === false) {
+  } @else if (canDownloadWithToken && (canDownload === false)) {
     <!-- If the user can download the file by token, and NOT normally show a lock open icon -->
     <span role="img"
     [attr.aria-label]="'file-download-link.secure-access' | translate"