Address review feedback

Author: mukeshpanchal27

README.md

@@ -23,10 +23,10 @@ This Action commits the contents of your Git tag to the WordPress.org plugin rep
 * `VERSION` - defaults to the tag name; do not recommend setting this except for testing purposes.
 * `ASSETS_DIR` - defaults to `.wordpress-org`, customizable for other locations of WordPress.org plugin repository-specific assets that belong in the top-level `assets` directory (the one on the same level as `trunk`).
 * `BUILD_DIR` - defaults to `false`. Set this flag to the directory where you build your plugins files into, then the action will copy and deploy files from that directory. Both absolute and relative paths are supported. The relative path if provided will be concatenated with the repository root directory. All files and folders in the build directory will be deployed, `.disignore` or `.gitattributes` will be ignored.
-* `DRY_RUN` - defaults to `false`. Set `true` to skip the final commit step and check all the debugging processes.
 
 ### Inputs
-* `generate-zip` - Generate a ZIP file from the SVN `trunk` directory. Outputs a `zip-path` variable for use in further workflow steps. Defaults to false.
+* `generate-zip` - Generate a ZIP file from the SVN `trunk` directory. Outputs a `zip-path` variable for use in further workflow steps. Defaults to `false`.
+* `dry-run` - Set `true` to skip the final commit step and check all the debugging processes. Defaults to `false`.
 
 ### Outputs
 * `zip-path` - The path to the ZIP file generated if `generate-zip` is set to `true`. Fully qualified including the filename, intended for use in further workflow steps such as uploading release assets.

deploy.sh

@@ -20,13 +20,8 @@ if [[ -z "$SVN_PASSWORD" ]]; then
 	exit 1
 fi
 
-# Check if the DRY_RUN ENV variable is set, otherwise set it to false.
-if [[ -z "$DRY_RUN" ]]; then
-	DRY_RUN=false;
-fi
-
-if [[ "$DRY_RUN" == true ]]; then
-	echo "ℹ︎ DRY_RUN is true"
+if $DRY_RUN; then
+	echo "ℹ︎ Dry run: no files will be committed to subversion."
 fi
 
 # Allow some ENV variables to be customized
@@ -161,8 +156,8 @@ svn update
 
 svn status
 
-if [[ "$DRY_RUN" == true ]]; then
-  echo "➤ Debug mode: Files not committed."
+if $DRY_RUN; then
+  echo "➤ Dry run: Files not committed."
 else
   echo "➤ Committing files..."
   svn commit -m "Update to version $VERSION from GitHub" --no-auth-cache --non-interactive  --username "$SVN_USERNAME" --password "$SVN_PASSWORD"