reverse: Bidirectional links between modules create inconsistent behavior

Author: remimd

injection/_core/module.py

@@ -118,14 +118,6 @@ class ModuleEventProxy(ModuleEvent):
     def __str__(self) -> str:
         return f"`{self.module}` has propagated an event: {self.origin}"
 
-    @property
-    def is_duplicate(self) -> bool:
-        module, origin = self.module, self.origin
-        return any(
-            module is event.module and origin is event.origin
-            for event in self.proxy_history
-        )
-
     @property
     def origin(self) -> Event:
         reversed_proxy_history = reversed(tuple(self.proxy_history))
@@ -170,9 +162,7 @@ def __str__(self) -> str:
 
 
 @dataclass(frozen=True, slots=True)
-class UnlockCalled(Event):
-    module: Module
-
+class UnlockCalled(ModuleEvent):
     def __str__(self) -> str:
         return f"`{self.module}.unlock` has been called."
 
@@ -875,12 +865,8 @@ def remove_listener(self, listener: EventListener) -> Self:
         self.__channel.remove_listener(listener)
         return self
 
-    def on_event(self, event: Event, /) -> ContextManager[None] | None:
+    def on_event(self, event: Event, /) -> ContextManager[None]:
         self_event = ModuleEventProxy(self, event)
-
-        if self_event.is_duplicate:
-            return None
-
         return self.dispatch(self_event)
 
     @contextmanager
@@ -894,17 +880,9 @@ def dispatch(self, event: Event, *, lock_bypass: bool = False) -> Iterator[None]
             finally:
                 self.__debug(event)
 
-    def _iter_brokers(self, visited: set[Module] | None = None, /) -> Iterator[Broker]:
-        if visited is None:
-            visited = set()
-
-        if self in visited:
-            return
-
-        visited.add(self)
-
+    def _iter_brokers(self) -> Iterator[Broker]:
         for module in self.__modules:
-            yield from module._iter_brokers(visited)
+            yield from module._iter_brokers()
 
         yield self.__locator
 

injection/loaders.py

@@ -176,12 +176,12 @@ def _unload(self, name: str, /) -> None:
 
     def __init_subsets_for(self, module: Module) -> Module:
         if not self.__is_empty and not self.__is_initialized(module):
-            self.__mark_initialized(module)
             target_modules = tuple(
                 self.__init_subsets_for(mod(name))
                 for name in self.module_subsets.get(module.name, ())
             )
             module.init_modules(*target_modules)
+            self.__mark_initialized(module)
 
         return module
 

tests/core/test_module.py

@@ -292,16 +292,6 @@ def test_use_with_module_already_in_use_raise_module_error(
 
         event_history.assert_length(1)
 
-    def test_use_with_bidirectional_use(self, module, event_history):
-        second_module = Module()
-        third_module = Module()
-
-        module.use(second_module)
-        second_module.use(module)
-        module.use(third_module)
-
-        event_history.assert_length(4)
-
     """
     stop_using
     """

tests/loaders/test_profile_loader.py

@@ -108,28 +108,6 @@ class B(A): ...
 
         assert type(find_instance(A)) is A
 
-    def test_load_with_bidirectional_link(self):
-        profile_name_1 = uuid4().hex
-        profile_name_2 = uuid4().hex
-
-        @mod(profile_name_1).injectable
-        class BaseConfig: ...
-
-        @mod(profile_name_2).injectable
-        @dataclass
-        class Dependency:
-            config: BaseConfig
-
-        loader = ProfileLoader(
-            {
-                profile_name_1: [profile_name_2],
-                profile_name_2: [profile_name_1],
-            }
-        )
-
-        with loader.load(profile_name_1):
-            assert find_instance(Dependency)
-
     def test_load_with_default_profile_do_nothing(self):
         default_profile_name = mod().name
         global_profile_name = uuid4().hex